Mark, do not forget to update documentation with certain usecase(s). Configure your tool (prefer IntelliJ IDEA) with code style, see the instructions in https://maven.apache.org/developers/conventions/code.html# IntelliJ_IDEA_4.5.2B and download https://maven.apache.org/developers/maven-idea-codestyle.xml
On Sat, Apr 6, 2019 at 8:48 AM Tibor Digana <[email protected]> wrote: > Mark, provide a patch including the unit tests in pull request on GitHub. > We are spending the time with tasks related to our long standing plan. > > On Fri, Apr 5, 2019 at 10:35 AM Robert Scholte <[email protected]> > wrote: > >> I think what Mark means is a jdkToolchain parameter[1] like >> maven-compiler-plugin. >> This way you can execute with several different toolchains within the >> same >> Maven run. >> To me it makes sense to add that to surefire/failsafe >> >> Robert >> >> [1] >> >> https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#jdkToolchain >> >> On Thu, 04 Apr 2019 23:54:38 +0200, Tibor Digana <[email protected]> >> >> wrote: >> >> > You can use Toolchain with Failsafe plugin: >> > https://maven.apache.org/surefire/maven-surefire-plugin/java9.html >> > but you can configure multiple executions and phases for the >> > maven-toolchains-plugin. >> > >> > On Thu, Apr 4, 2019 at 11:09 PM Mark Derricutt <[email protected]> wrote: >> > >> >> On 5 Apr 2019, at 6:29, Robert Scholte wrote: >> >> >> >> If you want to test the jar, you must use the failsafe plugin (or bind >> >> surefire to the integration-test phase) >> >> >> >> Can/could failsafe take a toolchain id as config, then you could >> >> configure >> >> additional executions using each toolchain you wanted? >> >> ------------------------------ >> >> >> >> "The ease with which a change can be implemented has no relevance at >> all >> >> to whether it is the right change for the (Java) Platform for all >> >> time." — >> >> Mark Reinhold. >> >> >> >> Mark Derricutt >> >> http://www.theoryinpractice.net >> >> http://www.chaliceofblood.net >> >> http://plus.google.com/+MarkDerricutt >> >> http://twitter.com/talios >> >> http://facebook.com/mderricutt >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
