Hi,
I am working on mx.containers.Panel
It has many variables and methods that are using mx_internal
e.g. Variable
mx_internal var _showCloseButton:Boolean = false;
Method
mx_internal function getStatusTextField():IUITextField
{
return statusTextField;
}As use namespace mx_internal; and import mx.core.mx_internal; are
commented in source files .
I am getting errors on these variables and methods
e.g
[java]
D:\out\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\container
s\Panel.as(1796):
col: 6 function 'getStatusTextField' will be scoped to the default
namespace: mx.containers.Panel: internal. It will not be visible outside of
this package.
[java]
[java] function getStatusTextField():IUITextField
Should I comment all of these variables and methods ?
Or
Should I make all of these variables and methods Public?
For Reference I am sharing link. So you don't need to find this file in
flex-sdk , We can find the files using below given link:
Flex-sdk mx. containers.Panel:
https://www.dropbox.com/s/6xb1jp2efwuwnam/PanelFlex.as?dl=0
Royale : https://www.dropbox.com/s/rty3twj1cpmzwbi/Panel.as?dl=0
Thanks in Advance.
Alina Kazi
-----Original Message-----
From: Alina Kazi [mailto:[email protected]]
Sent: Monday, April 02, 2018 11:08 AM
To: [email protected]
Subject: RE: Work on Emulation
Hi Piotr,
Thanks Piotr.
I am trying to add another pull request for SliderEvent.as file. but when I
added this file manually at
https://github.com/alinakazi/royale-asjs/tree/mxRoyaleAQ/frameworks/projects
/MXRoyale/src/main/royale/mx/events
and commit it.
Commit auto added to previous Pull Request :
https://github.com/apache/royale-asjs/pull/138
Is it ok to do multiple commits on same pull Request instead of creating New
Pull Request for each file?
How Can I delete these Closed Pull Requests?
https://github.com/apache/royale-asjs/pull/139
and
https://github.com/apache/royale-asjs/pull/140
-Alina
-----Original Message-----
From: piotrz [mailto:[email protected]]
Sent: Friday, March 30, 2018 5:14 PM
To: [email protected]
Subject: Re: Work on Emulation
I see your new pull request and it doesn't looks good. [1] As you can see on
the screenshot you did it against develop from feature/MXRoyale and it
contains 94 commits.
<http://apache-royale-users.20374.n8.nabble.com/file/t1/new_pull_request.png
>
The old one is being done correctly. You have used your branch ->
apache:feature/MXRoyale from alinakazi:mxRoyaleAQ
<http://apache-royale-users.20374.n8.nabble.com/file/t1/old_pull_Request.png
>
[1] https://github.com/apache/royale-asjs/pull/139/commits
Thanks,
Piotr
--
Sent from: http://apache-royale-users.20374.n8.nabble.com/
