Thanks J
New branch Created : https://github.com/alinakazi/royale-asjs/tree/mxRoyalePanel Copied MX Panel from flex-sdk to New branch (mxRoyalePanel) Pull Request : https://github.com/apache/royale-asjs/pull/141 -Alina Kazi From: Piotr Zarzycki [mailto:[email protected]] Sent: Monday, April 02, 2018 1:22 PM To: [email protected] Subject: Re: Work on Emulation Alina, You cannot delete pull request. You can only close it, so we are good with 139 and 140. They are closed. Your pull request 138 now looks great! :) Whenever you are going to push some bigger changes you should create new branches. If you are working right now on Panel - probably new branch with your changes would be the best. Our pull request will looks than cleaner. - That is just my recommendation. In general congrats for your first pull request to Apache Royale project!! :) Thanks, Piotr 2018-04-02 8:08 GMT+02:00 Alina Kazi <[email protected]>: Hi Piotr, Thanks Piotr. I am trying to add another pull request for SliderEvent.as file. but when I added this file manually at https://github.com/alinakazi/royale-asjs/tree/mxRoyaleAQ/frameworks/projects <https://github.com/alinakazi/royale-asjs/tree/mxRoyaleAQ/frameworks/projects%0d%0a/MXRoyale/src/main/royale/mx/events> /MXRoyale/src/main/royale/mx/events and commit it. Commit auto added to previous Pull Request : https://github.com/apache/royale-asjs/pull/138 Is it ok to do multiple commits on same pull Request instead of creating New Pull Request for each file? How Can I delete these Closed Pull Requests? https://github.com/apache/royale-asjs/pull/139 and https://github.com/apache/royale-asjs/pull/140 -Alina -----Original Message----- From: piotrz [mailto:[email protected]] Sent: Friday, March 30, 2018 5:14 PM To: [email protected] Subject: Re: Work on Emulation I see your new pull request and it doesn't looks good. [1] As you can see on the screenshot you did it against develop from feature/MXRoyale and it contains 94 commits. <http://apache-royale-users.20374.n8.nabble.com/file/t1/new_pull_request.png > The old one is being done correctly. You have used your branch -> apache:feature/MXRoyale from alinakazi:mxRoyaleAQ <http://apache-royale-users.20374.n8.nabble.com/file/t1/old_pull_Request.png > [1] https://github.com/apache/royale-asjs/pull/139/commits Thanks, Piotr -- Sent from: http://apache-royale-users.20374.n8.nabble.com/ -- Piotr Zarzycki Patreon: https://www.patreon.com/piotrzarzycki
