Thanks a lot! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov
On Fri, Jul 18, 2014 at 6:23 PM, Jered Myers <jer...@maplewoodsoftware.com> wrote: > Done > > > On 07/18/2014 12:44 AM, Martin Grigorov wrote: > >> Can you send a PR for master branch (Wicket 7) too ? >> git cherry-pick fails to do it automatically :-/ >> >> Martin Grigorov >> Wicket Training and Consulting >> https://twitter.com/mtgrigorov >> >> >> On Fri, Jul 18, 2014 at 9:34 AM, Martin Grigorov <mgrigo...@apache.org> >> wrote: >> >> Thank you! >>> >>> Martin Grigorov >>> Wicket Training and Consulting >>> https://twitter.com/mtgrigorov >>> >>> >>> On Thu, Jul 17, 2014 at 7:05 PM, Jered Myers < >>> jer...@maplewoodsoftware.com >>> >>>> wrote: >>>> I added the pull request for lightbox2. lightbox2-examples didn't need >>>> to be updated. >>>> >>>> Jered >>>> >>>> >>>> On 07/17/2014 12:27 AM, Martin Grigorov wrote: >>>> >>>> Hi, >>>>> >>>>> Do you want to contribute back ? >>>>> Please create a Pull Request at with the updates/fixes at >>>>> https://github.com/wicketstuff/core >>>>> Thanks! >>>>> >>>>> Martin Grigorov >>>>> Wicket Training and Consulting >>>>> https://twitter.com/mtgrigorov >>>>> >>>>> >>>>> On Thu, Jul 17, 2014 at 12:14 AM, Jered Myers < >>>>> jer...@maplewoodsoftware.com> >>>>> wrote: >>>>> >>>>> The WicketStuff version of the JavaScript file was out of date. >>>>> After I >>>>> >>>>>> fixed the JavaScript both the thumbnail and full image displayed. The >>>>>> close image icon still wasn't showing, so I just rolled my own version >>>>>> from >>>>>> http://lokeshdhakar.com/projects/lightbox2/. I think all that needs >>>>>> to >>>>>> be done to fix WicketStuff is to copy down the resource files and to >>>>>> add >>>>>> the data-lightbox attribute to onComponentTag in LightboxLink. >>>>>> >>>>>> Jered >>>>>> >>>>>> >>>>>> On 07/14/2014 10:37 AM, Jered Myers wrote: >>>>>> >>>>>> I am having trouble getting the wicketstuff Lightbox2 plugin >>>>>> >>>>>>> integration >>>>>>> working. I am using the basic example with image resources at the >>>>>>> bottom >>>>>>> of https://github.com/wicketstuff/core/wiki/ >>>>>>> Lightbox2-Plugin-Integration. >>>>>>> The thumbnail displays just fine, but when I click on the thumbnail >>>>>>> only >>>>>>> the mask for the page shows up and the image is missing. Does >>>>>>> anybody >>>>>>> have >>>>>>> this plugin working? The examples don't seem to work for me either >>>>>>> (6.15.0). I tried adding "data-lightbox" attribute per the ( >>>>>>> http://lokeshdhakar.com/projects/lightbox2/) website, but it didn't >>>>>>> seem >>>>>>> to help. Here is my code where res is an instance of a class that >>>>>>> holds the >>>>>>> ResourceReferences: >>>>>>> >>>>>>> add(new LightboxLink("imageLink", res.getFullImage()) { >>>>>>> private static final long serialVersionUID = 1L; >>>>>>> >>>>>>> @Override >>>>>>> protected void onComponentTag(ComponentTag tag) >>>>>>> { >>>>>>> super.onComponentTag(tag); >>>>>>> tag.put("data-lightbox", getMarkupId()); >>>>>>> } >>>>>>> }.add(new Image("imageFile", res.getThumbnail()))); >>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------ >>>>>>> --------- >>>>>>> >>>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>>>>> For additional commands, e-mail: users-h...@wicket.apache.org >>>>>> >>>>>> >>>>>> >>>>>> ------------------------------------------------------------ >>>> --------- >>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>>> For additional commands, e-mail: users-h...@wicket.apache.org >>>> >>>> >>>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
