LGTM. Comments:
http://codereview.chromium.org/8763/diff/3/5 File tools/utils.py (right): http://codereview.chromium.org/8763/diff/3/5#newcode56 Line 56: def GuessSystem(): How about unifying this with the GuessOS in SConstruct? Maybe rename this GuessSystem to GuessOS let it return 'win32' in the windows case and use that from SConstruct? http://codereview.chromium.org/8763/diff/3/5#newcode68 Line 68: Extra new line here? http://codereview.chromium.org/8763/diff/3/5#newcode70 Line 70: return GuessSystem() == 'windows' If you change GuessSystem/GuessOS to return 'win'32 you should change this too. http://codereview.chromium.org/8763 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
