http://codereview.chromium.org/8763/diff/3/4 File tools/test.py (right):
http://codereview.chromium.org/8763/diff/3/4#newcode922 Line 922: return None On 2008/10/31 12:53:47, Christian Plesner Hansen wrote: > 'return None' == 'return' The test.py file uses 'return None' all over the place. http://codereview.chromium.org/8763/diff/3/5 File tools/utils.py (right): http://codereview.chromium.org/8763/diff/3/5#newcode56 Line 56: def GuessSystem(): On 2008/10/31 12:41:52, Kasper Lund wrote: > How about unifying this with the GuessOS in SConstruct? Maybe rename this > GuessSystem to GuessOS let it return 'win32' in the windows case and use that > from SConstruct? Done. Renamed to GuessOS and used from SConstruct. Changed 'windows' to 'win32'. There was no mentioning of 'windows in any test/**/*.status file. http://codereview.chromium.org/8763/diff/3/5#newcode57 Line 57: system = platform.system() On 2008/10/31 12:53:47, Christian Plesner Hansen wrote: > What about doing .lower() here and then removing it elsewhere? I decided against .lower() after all. http://codereview.chromium.org/8763/diff/3/5#newcode68 Line 68: On 2008/10/31 12:41:52, Kasper Lund wrote: > Extra new line here? Added. http://codereview.chromium.org/8763/diff/3/5#newcode70 Line 70: return GuessSystem() == 'windows' On 2008/10/31 12:41:52, Kasper Lund wrote: > If you change GuessSystem/GuessOS to return 'win'32 you should change this too. Done. http://codereview.chromium.org/8763 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
