Lgtm

http://codereview.chromium.org/8763/diff/3/4
File tools/test.py (right):

http://codereview.chromium.org/8763/diff/3/4#newcode922
Line 922: return None
'return None' == 'return'

http://codereview.chromium.org/8763/diff/3/5
File tools/utils.py (right):

http://codereview.chromium.org/8763/diff/3/5#newcode57
Line 57: system = platform.system()
What about doing .lower() here and then removing it elsewhere?

http://codereview.chromium.org/8763

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to