LGTM, with comments.
http://codereview.chromium.org/100336/diff/1/3 File src/globals.h (right): http://codereview.chromium.org/100336/diff/1/3#newcode54 Line 54: #ifdef _WIN32 Is _WIN32 correct for 64 bits? Shouldn't it rather be _MSC_VER? http://codereview.chromium.org/100336/diff/1/3#newcode58 Line 58: #define UINT64_C(x) (x ## ULL) Or should these be by architecture (so ##UL on GCC/LP64 and #UUL on GCC/ILP32)? http://codereview.chromium.org/100336/diff/1/3#newcode96 Line 96: const intptr_t kObjectAlignmentMask = (ONE << kObjectAlignmentBits) - 1; How about ~(-1 << kObjectAlignmentBits) instead? All the masks are int values anyway, so the calculation can be done on ints. http://codereview.chromium.org/100336 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
