http://codereview.chromium.org/100336/diff/1/3 File src/globals.h (right):
http://codereview.chromium.org/100336/diff/1/3#newcode54 Line 54: #ifdef _WIN32 On 2009/05/04 12:43:11, Lasse Reichstein wrote: > Is _WIN32 correct for 64 bits? Shouldn't it rather be _MSC_VER? Done. http://codereview.chromium.org/100336/diff/1/3#newcode58 Line 58: #define UINT64_C(x) (x ## ULL) On 2009/05/04 12:43:11, Lasse Reichstein wrote: > Or should these be by architecture (so ##UL on GCC/LP64 and #UUL on GCC/ILP32)? I don't know that these are defined. http://codereview.chromium.org/100336/diff/1/3#newcode96 Line 96: const intptr_t kObjectAlignmentMask = (ONE << kObjectAlignmentBits) - 1; On 2009/05/04 12:43:11, Lasse Reichstein wrote: > How about > ~(-1 << kObjectAlignmentBits) > instead? All the masks are int values anyway, so the calculation can be done on > ints. This change is removed, so that masks of more than 32 bits will give a compiler error, for portability. http://codereview.chromium.org/100336 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
