This is a general comment about using V8_ARCH_X64 as the 64-bit marker while porting and not only a particular comment about Bill's change.
Please clean this up now and stick to the clean definition before it gets a lot harder to deal with. Some ideas: Use the automatic defines __WORDSIZE or __LP64__ or something that is defined in one place inside globals.h or v8.h based on the compiler automatic defines: #if defined(__LP64__) || (__LLP64__) #define V8_64BIT 1 #endif Thanks! -Ivan http://codereview.chromium.org/100336/diff/11/1006 File src/globals.h (right): http://codereview.chromium.org/100336/diff/11/1006#newcode87 Line 87: #ifdef V8_ARCH_X64 There are potentially other 64-bit architectures outside x64. Please do not "improve" the code for 64-bit cleanliness while making it harder to port to other architectures. This will serve as a disservice in the long time. Thanks! http://codereview.chromium.org/100336/diff/11/1006#newcode124 Line 124: #ifdef V8_ARCH_X64 ditto! http://codereview.chromium.org/100336 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
