It looks OK after moving the inlined functions as Ivan suggests. I presume we're just not far enough along to have x64 assembler tests yet? If not, it would be a good goal to get there soon.
http://codereview.chromium.org/115571/diff/1003/7 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/115571/diff/1003/7#newcode833 Line 833: #undef EMIT It's also weird that they don't match the naming scheme used in the rest of the assembler. You should be consistent (match the ia32 naming scheme everwhere, or switch to the CamelCase naming scheme everwhere). http://codereview.chromium.org/115571 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
