Comments addressed, functions renamed and moved.
http://codereview.chromium.org/115571/diff/1003/7 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/115571/diff/1003/7#newcode833 Line 833: #undef EMIT On 2009/05/22 07:20:27, Kevin Millikin wrote: > It's also weird that they don't match the naming scheme used in the rest of the > assembler. > You should be consistent (match the ia32 naming scheme everwhere, or switch to > the CamelCase naming scheme everwhere). Functions moved to -inl.h file, renamed to emit_rex_64. http://codereview.chromium.org/115571 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
