I forgot to add the -inl.h file to the changelist, so the x64 build must be broken. I see there are more changes we should make, so should I revert the commit, or add the -inl.h file to it? The change is uploaded, and I can add the other two files to it if we want to change them.
I was going to use separate emit_rex_32 and emit_rex_64, rather than including the REX.W prefix as an operand size argument, but I can change that. mov will be aliased to mov_q, the 64-bit move. mov_l will be implemented for the 32 bit move. I could use a general REX emit, with w, r, x, and b as arguments, but I am currently using more special-case functions: emitting REX given two registers, and emitting REX given a register and an Operand, which should usually have a SIB byte. I committed based on the review from Kevin, but I can see we may make more changes - I'll create a new changelist and upload. On Fri, May 22, 2009 at 10:05 AM, Petr Kobalíček <[email protected]>wrote: > > movq must be used with REX.W prefix (W bit set) > > I implemented this using this code in AsmJit: > > if (w || r || x || b) > { > _emitByte(0x40 | (w << 3) | (r << 2) | (x << 1) | b); > } > > - Petr > > 2009/5/22 <[email protected]>: > > > > > > http://codereview.chromium.org/115571/diff/1005/14 > > File src/x64/assembler-x64.cc (right): > > > > http://codereview.chromium.org/115571/diff/1005/14#newcode279 > > Line 279: emit_rex_64(dst, src); > > Will all mov instructions need the emit_rex_64 prefix? How are you going > > to distinguish movl and movq instructions? > > > > Can you also please upload the -inl.h files? > > > > http://codereview.chromium.org/115571 > > > > > > > > > > > -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
