Change the commit message to say "Add unit test for the 64-bit assembler."
I'm concerned about multiplication of testing configurations. Is it possible to arch=x64 on Windows and Mac? If so, does this test pass? http://codereview.chromium.org/115707/diff/11/12 File test/cctest/test-assembler-x64.cc (right): http://codereview.chromium.org/115707/diff/11/12#newcode47 Line 47: // convention is used on 64-bit windows. What happens if the tests are run for arch=x64 on Windows or Mac? Does it not even get this far? http://codereview.chromium.org/115707/diff/11/12#newcode57 Line 57: v8::internal::byte* buffer; It seems easier to just use OS:Allocate here instead of virtual memory. You don't have to write v8::internal:: here, do you? I think it reads better to use it everywhere or not use it at all, consistently. http://codereview.chromium.org/115707 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
