Comments addressed. Windows platform is currently not implemented.
http://codereview.chromium.org/115707/diff/11/12 File test/cctest/test-assembler-x64.cc (right): http://codereview.chromium.org/115707/diff/11/12#newcode57 Line 57: v8::internal::byte* buffer; On 2009/05/22 13:20:54, Kevin Millikin wrote: > It seems easier to just use OS:Allocate here instead of virtual memory. > You don't have to write v8::internal:: here, do you? I think it reads better to > use it everywhere or not use it at all, consistently. Done. http://codereview.chromium.org/115707 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
