Currently arch=x64 doesn't work in Windows (it doesn't pass any extra flags to the compiler, but it assumes that we have a 64-bit memory model).It should "work" on Mac, since it uses GCC as well.
2009/5/22 kmillikin <[email protected]> > > Change the commit message to say "Add unit test for the 64-bit > assembler." > > I'm concerned about multiplication of testing configurations. Is it > possible to arch=x64 on Windows and Mac? If so, does this test pass? > > > http://codereview.chromium.org/115707/diff/11/12 > File test/cctest/test-assembler-x64.cc (right): > > http://codereview.chromium.org/115707/diff/11/12#newcode47 > Line 47: // convention is used on 64-bit windows. > What happens if the tests are run for arch=x64 on Windows or Mac? Does > it not even get this far? > > http://codereview.chromium.org/115707/diff/11/12#newcode57 > Line 57: v8::internal::byte* buffer; > It seems easier to just use OS:Allocate here instead of virtual memory. > > You don't have to write v8::internal:: here, do you? I think it reads > better to use it everywhere or not use it at all, consistently. > > http://codereview.chromium.org/115707 > > > > -- Lasse R.H. Nielsen [email protected] 'Faith without judgement merely degrades the spirit divine' Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K - Denmark - CVR nr. 28 86 69 84 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
