LGTM
http://codereview.chromium.org/113832/diff/1/2 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/113832/diff/1/2#newcode327 Line 327: emit(offset); This should be safe (code blocks can't be more than 2 gig in size). http://codereview.chromium.org/113832/diff/1/2#newcode336 Line 336: } This code might be used identically in other places where a label is emitted. How about making an emit(Label*) function? http://codereview.chromium.org/113832 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
