http://codereview.chromium.org/113832/diff/1/2 File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/113832/diff/1/2#newcode327 Line 327: emit(offset); On 2009/05/26 09:01:05, Lasse Reichstein wrote: > This should be safe (code blocks can't be more than 2 gig in size). I'm not sure if this is a comment or a suggestion. What do you mean? Do we need to check something we are not checking? http://codereview.chromium.org/113832/diff/1/2#newcode336 Line 336: } On 2009/05/26 09:01:05, Lasse Reichstein wrote: > This code might be used identically in other places where a label is emitted. > How about making an emit(Label*) function? I think there are no further cases to be implemented. But this is a good idea. http://codereview.chromium.org/113832/diff/9/1013#newcode318 Line 318: On 2009/05/26 12:14:41, Lasse Reichstein wrote: > Was this incorrect before? Yes it was. Cases with two register operands should all be implemented as src=r/m, dest=reg (an arbitrary choice). http://codereview.chromium.org/113832 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
