LGTM still applies.
http://codereview.chromium.org/113832/diff/1/2 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/113832/diff/1/2#newcode327 Line 327: emit(offset); On 2009/05/26 15:15:31, William Hesse wrote: > On 2009/05/26 09:01:05, Lasse Reichstein wrote: > > This should be safe (code blocks can't be more than 2 gig in size). > I'm not sure if this is a comment or a suggestion. What do you mean? Do we > need to check something we are not checking? Sorry, just my vague way of saying that I'm only 98% sure this is fine, so do double-check and correct me if I'm wrong. http://codereview.chromium.org/113832 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
