LGTM
http://codereview.chromium.org/151151/diff/1/2 File src/objects.cc (right): http://codereview.chromium.org/151151/diff/1/2#newcode5814 Line 5814: return NULL; We normally return Heap::undefined_value() when something is absent. http://codereview.chromium.org/151151/diff/1/2#newcode5822 Line 5822: PropertyAttributes* attrs) { Why attrs in one method and attributes in another? Make this one attributes again? http://codereview.chromium.org/151151 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
