Done. On Wed, Jul 1, 2009 at 8:19 PM, <[email protected]> wrote: > On 2009/07/01 15:44:47, antonm wrote: >> >> http://codereview.chromium.org/151151/diff/1/2#newcode5822 >> Line 5822: PropertyAttributes* attrs) { >> On 2009/07/01 15:06:59, Mads Ager wrote: >> > Why attrs in one method and attributes in another? Make this one > > attributes >> >> > again? > >> To fit ln. 5828 into single line :) If it was a bad idea, I'd revert > > of course. > > I would prefer readable names and break this one line. :-) > > And still LGTM! > > http://codereview.chromium.org/151151 >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
