Thanks a lot for review, Mads!
http://codereview.chromium.org/151151/diff/1/2 File src/objects.cc (right): http://codereview.chromium.org/151151/diff/1/2#newcode5814 Line 5814: return NULL; On 2009/07/01 15:06:59, Mads Ager wrote: > We normally return Heap::undefined_value() when something is absent. Done. http://codereview.chromium.org/151151/diff/1/2#newcode5822 Line 5822: PropertyAttributes* attrs) { On 2009/07/01 15:06:59, Mads Ager wrote: > Why attrs in one method and attributes in another? Make this one attributes > again? To fit ln. 5828 into single line :) If it was a bad idea, I'd revert of course. http://codereview.chromium.org/151151 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
