-Ivan
http://codereview.chromium.org/155924/diff/3/1008 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/155924/diff/3/1008#newcode51 Line 51: // complete runtime version. Bill since we only ever enter symbols into the dictionaries as keys executing the code generated by this function with a non-symbol string is a waste. Please update the comment to this extent. http://codereview.chromium.org/155924/diff/3/1008#newcode286 Line 286: // Is it a string? Excellent catch! http://codereview.chromium.org/155924/diff/3/1008#newcode297 Line 297: // and separately for strings with a computed hash and those without. Please keep the filter for symbols here as it is a waste to execute the dictionary load with a non-symbol string. http://codereview.chromium.org/155924 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
