http://codereview.chromium.org/155924/diff/2003/1016 File src/ia32/ic-ia32.cc (right):
http://codereview.chromium.org/155924/diff/2003/1016#newcode294 Line 294: __ CmpInstanceType(edx, FIRST_SYMBOL_TYPE); On 2009/07/23 11:41:51, Mads Ager wrote: > I find this misleading since FIRST_SYMBOL_TYPE is actually not an instance type > at all. I like the explict checking of kSymbolMask better. Done. http://codereview.chromium.org/155924/diff/2003/1018 File src/objects.h (right): http://codereview.chromium.org/155924/diff/2003/1018#newcode699 Line 699: FIRST_SYMBOL_TYPE = kSymbolTag On 2009/07/23 11:41:51, Mads Ager wrote: > This is not an instance type, so I find it misleading to have it here. Can't > you write the code using kSymbolTag explicitly? Done. http://codereview.chromium.org/155924 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
