http://codereview.chromium.org/155924/diff/3/1008 File src/ia32/ic-ia32.cc (right):
http://codereview.chromium.org/155924/diff/3/1008#newcode51 Line 51: // complete runtime version. On 2009/07/22 18:59:55, iposva wrote: > Bill since we only ever enter symbols into the dictionaries as keys executing > the code generated by this function with a non-symbol string is a waste. Please > update the comment to this extent. Done. http://codereview.chromium.org/155924/diff/3/1008#newcode297 Line 297: // and separately for strings with a computed hash and those without. On 2009/07/22 18:59:55, iposva wrote: > Please keep the filter for symbols here as it is a waste to execute the > dictionary load with a non-symbol string. Done. http://codereview.chromium.org/155924 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
