LGTM
http://codereview.chromium.org/159584/diff/9/1004 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/159584/diff/9/1004#newcode4968 Line 4968: if (!left_is_in_rax) __ movq(rax, left->reg()); Use movsxlq(rax, left->reg()) here and movsxlq(rax,rax) in the else branch. http://codereview.chromium.org/159584/diff/9/1004#newcode4977 Line 4977: __ idiv(right->reg()); Could we use idivl instead, and avoid the sign extensions? http://codereview.chromium.org/159584/diff/9/1004#newcode6611 Line 6611: __ idiv(rbx); If you change anything above, do it here too. http://codereview.chromium.org/159584 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
