LGTM
http://codereview.chromium.org/159584/diff/14/17 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/159584/diff/14/17#newcode5009 Line 5009: // zero. The frame is unchanged in this block, so local control The frame doesn't seem unchanged by the entire block (there is a frame_->Push). Could you rewrite the comment? http://codereview.chromium.org/159584/diff/14/17#newcode5059 Line 5059: __ movq(answer.reg(), left->reg()); Use movl? It might save a REX prefix byte. http://codereview.chromium.org/159584/diff/14/17#newcode6632 Line 6632: __ NegativeZeroTest(rdx, rcx, slow); // use ecx = x | y ecx => rcx in comment http://codereview.chromium.org/159584 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
