Drive by.

http://codereview.chromium.org/159584/diff/38/1017
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/159584/diff/38/1017#newcode5009
Line 5009: // and the target, so a Label can be used.
To me this is less precise than what was before.

Try: "The frame is unchanged on all paths reaching non_zero_result,
so..." or "There is no frame effect on any path reaching
non_zero_result, so...".

And write the same thing at both sites so the reader doesn't have to
puzzle out whether it's the same reason or a different one.

http://codereview.chromium.org/159584

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to