LGTM, except This change should go on branches/bleeding_edge and then merged to branches/1.2.
http://codereview.chromium.org/160556/diff/7/1009 File SConstruct (right): http://codereview.chromium.org/160556/diff/7/1009#newcode129 Line 129: 'CPPDEFINES': ['V8_SHARED'], How about using BUILDING_V8_SHARED to use the same define as on Windows? http://codereview.chromium.org/160556 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
