On Tue, Aug 4, 2009 at 12:30 AM, <[email protected]> wrote: > LGTM, except > > This change should go on branches/bleeding_edge and then merged to > branches/1.2.
Ok, no problem, I'll switch it. Both o3d and chrome use the 1.2 branch, so it'd be good to merge it indeed. Antoine > > > http://codereview.chromium.org/160556/diff/7/1009 > File SConstruct (right): > > http://codereview.chromium.org/160556/diff/7/1009#newcode129 > Line 129: 'CPPDEFINES': ['V8_SHARED'], > How about using BUILDING_V8_SHARED to use the same define as on Windows? > > http://codereview.chromium.org/160556 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
