http://codereview.chromium.org/160556/diff/7/1009 File SConstruct (right):
http://codereview.chromium.org/160556/diff/7/1009#newcode129 Line 129: 'CPPDEFINES': ['V8_SHARED'], On 2009/08/04 07:43:53, piman wrote: > On 2009/08/04 07:30:55, Søren Gjesse wrote: > > How about using BUILDING_V8_SHARED to use the same define as on Windows? > It's defined both when compiled and used, which is why I chose a different > symbol, but it doesn't matter to me. If you want it for both then I suggest to use BUILDING_V8_SHARED when building the shared library (that will mean moving it to V8_EXTRA_FLAGS in SConstruct), and use USING_V8_SHARED when building the client. In v8.h both these defines should end up have the same effect. If you move it from to V8_EXTRA_FLAGS it will only be defined when building V8 not when using it. You are right - keep it as V8_SHARED http://codereview.chromium.org/160556 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
