Could you add test-parsing tests for all kinds of legal and illegal cases?
(That's the most streamlined way of testing illegal syntax, and testing
PreParser.)
test-parsing.cc and mjsunit have some minor amount of duplication... If
you're
just testing that stuff is getting parsed without an error, I'd say
test-parsing
is the way to go. In the mjsunit tests, it would be good to assert that the
right thing happens when the code is executed (something we cannot do in
test-parsing.cc). Wdyt?
Could you also add a test where a comment (single or multiline) starts on
the
same line as yield?
https://codereview.chromium.org/348893007/diff/1/test/mjsunit/harmony/generators-parsing.js
File test/mjsunit/harmony/generators-parsing.js (right):
https://codereview.chromium.org/348893007/diff/1/test/mjsunit/harmony/generators-parsing.js#newcode39
test/mjsunit/harmony/generators-parsing.js:39: function* g() { yield; }
Could you add a test that calls this kind of function (which has yield
without a value) and assert that the right thing is yielded? (What is
the right thing in this case?)
https://codereview.chromium.org/348893007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
