On 2014/06/26 10:41:52, marja wrote:
Could you add test-parsing tests for all kinds of legal and illegal cases?
(That's the most streamlined way of testing illegal syntax, and testing
PreParser.)

To clarify, are you suggesting that I move the entirety of generators-parsing.js to test-parsing? With the exception of the newly added case on line 63, none of
these generators are actually executed; this file is just for parsing tests.

Could you also add a test where a comment (single or multiline) starts on the
same line as yield?

Sure.

https://codereview.chromium.org/348893007/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to