On 2014/06/27 09:55:36, marja wrote:
The reply was:
I don't have super strong opinions on this. We'd need to find a good
balance
wrt
which tests to put to mjsunit and which to test-parsing.cc.
mjsunit:
Pros: can run code, easy to understand, self contained
Cons: doesn't invoke PreParser at all, testing erroneous constructs is
cumbersome
test-parsing.cc:
Pros: can easily test erroneous constructs, can test combinations easily
(like,
test all combinations of function signature and function body), can test
PreParser (and that Parser and PreParser give the same errors), can test
the
same code with all combinations of flags
Cons: not mjsunit
So I was suggesting that maybe some of the tests you have for yielding
are a
good fit for test-parsing.cc. Wdyt?
Cool, sounds good to me. I'll just copy most of them over I guess -- I
suppose
it can't hurt to test something twice. Tx for the feedback :)
https://codereview.chromium.org/348893007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
