https://codereview.chromium.org/352823003/diff/1/src/ostreams.h#newcode101
src/ostreams.h:101: explicit OFStream(const char* p) : f_(fopen(p, "w")),
own_(true) { }
On 2014/06/25 14:48:16, Benedikt Meurer wrote:
> Please remove this constructor. It performs absolutely no error
checking on
the
> result of fopen.
But this would be in line with ignoring basically all I/O errors in the
rest
of
v8... :-D More seriously: Removing it is fine with me, but then I'll
remove
close(), too, leaving just a plain decorator for FILE*.
That sounds like a plan. I was about to complain about close() too... :-)
https://codereview.chromium.org/352823003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
