Just one comment, rest looks OK to me, but I am no std expert at all.
https://codereview.chromium.org/352823003/diff/1/src/ostreams.cc
File src/ostreams.cc (right):
https://codereview.chromium.org/352823003/diff/1/src/ostreams.cc#newcode10
src/ostreams.cc:10: #define snprintf sprintf_s
Can we use SNPrintF from utils.h instead of using compiler-specific
#ifdef's here?
https://codereview.chromium.org/352823003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
