Please add tests.
https://codereview.chromium.org/352823003/diff/1/src/ostreams.h
File src/ostreams.h (right):
https://codereview.chromium.org/352823003/diff/1/src/ostreams.h#newcode101
src/ostreams.h:101: explicit OFStream(const char* p) : f_(fopen(p,
"w")), own_(true) { }
Please remove this constructor. It performs absolutely no error checking
on the result of fopen.
https://codereview.chromium.org/352823003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
