On 2014/07/07 at 13:21:05, marja wrote:
On 2014/07/07 13:18:45, marja wrote:
> Unfortunately, "make qc" still fails :( It's a presubmit error this
time.
Are
> you uploading with --bypass-hooks or how did it actually let you upload
the
> patch set?!
... also, I *could* just hijack this CL and upload a fixed patch set, I
just
thought that it would be good to get the workflow ironed out, so that you're
using the same compiler and the same checks than we do, so that when I try
to
commit it actually succeeds...
It seems that my copy of depot_tools was a bit old, and some things have
changed in cpplint. I have updated it, and cpplint picked a few things
more, which are now fixed.
https://codereview.chromium.org/160073006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
