On 2014/07/07 at 15:40:22, aperez wrote:
On 2014/07/07 at 15:08:17, marja wrote:
> On 2014/07/07 15:01:18, marja wrote:
> > Okay, now this gets silly. make qc runs, but I get this error when I'm
trying to
> > commit:
> >
> > ** Presubmit Warnings **
> > Your patch is not formatted, please run git cl format
>
> Hmm, so the thing seems to be that maybe you don't have clang format in
your
checkout. This whine should occur when you git cl upload.
>
> So pls run "make dependencies" to get clang format and try to upload
again..
you should see this whine. :)
Mmmhh, this does not show up here somehow. Let's see if doing
"git clean -xdf && make dependencies" does the trick...
Ok, that worked. Now this issue shows and I can also do "git cl format"
and it will work. But clang-format wants to do some odd-looking things
to "test/cctest/test-parsing.cc"... Should we trust it?
https://codereview.chromium.org/160073006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
