On 2014/07/08 04:10:47, aperez wrote:
On 2014/07/07 at 20:32:52, marja wrote:
> On 2014/07/07 20:30:05, aperez wrote:
>
> > Ok, that worked. Now this issue shows and I can also do "git cl
format"
> > and it will work. But clang-format wants to do some odd-looking things
> > to "test/cctest/test-parsing.cc"... Should we trust it?
>
> What does it want to do? Can you upload a patch set with what it
suggests?
The last update has what "git cl format" produces. What it does with
"test-parsing.cc" making two columns of the data... I am not completely
sure about that.
Yes, that is truly horrible. I filed a bug against clang-format.
So let's do it like this: I'm going to commit this patch set as is. And if
we
get a decision that either 1) it's okay to rebel against clang-format or 2)
clang-format changes its behavior, we'll just commit another CL which
reformats
test-parsing.cc back to sanity again.
https://codereview.chromium.org/160073006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
