https://codereview.chromium.org/378303003/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/378303003/diff/1/src/parser.cc#newcode1168
src/parser.cc:1168: if (allow_harmony_scoping() && strict_mode() ==
STRICT) {
(See below; isn't allow_harmony_scoping() necessarily true here.)
https://codereview.chromium.org/378303003/diff/1/src/parser.cc#newcode1557
src/parser.cc:1557: if (allow_harmony_scoping() && strict_mode() ==
STRICT) {
Ditto
https://codereview.chromium.org/378303003/diff/1/src/parser.cc#newcode1672
src/parser.cc:1672: if (allow_harmony_scoping() && strict_mode() ==
STRICT) {
I don't think we need to check allow_harmony_scoping() here; if it's not
allowed, we don't get Token::LET. Also, below you don't check it either.
https://codereview.chromium.org/378303003/diff/1/src/preparser.cc
File src/preparser.cc (right):
https://codereview.chromium.org/378303003/diff/1/src/preparser.cc#newcode175
src/preparser.cc:175: if (allow_harmony_scoping() && strict_mode() ==
STRICT) {
Ditto
https://codereview.chromium.org/378303003/diff/1/src/preparser.cc#newcode306
src/preparser.cc:306: if (allow_harmony_scoping() && strict_mode() ==
STRICT) {
Ditto
https://codereview.chromium.org/378303003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
