On 2014/07/09 14:43:11, marja wrote:
On 2014/07/09 14:28:50, rossberg wrote:
> https://codereview.chromium.org/378303003/diff/1/src/parser.cc
> File src/parser.cc (right):
>
>
https://codereview.chromium.org/378303003/diff/1/src/parser.cc#newcode1672
> src/parser.cc:1672: if (allow_harmony_scoping() && strict_mode() ==
STRICT)
{
> On 2014/07/09 14:24:45, marja wrote:
> > I don't think we need to check allow_harmony_scoping() here; if it's
not
> > allowed, we don't get Token::LET. Also, below you don't check it
either.
>
> Yes, this was on purpose -- I wanted to be able to grep for
harmony-scoping
> specific code paths easily. But I can remove that if you prefer.
I don't have an opinion, but now it's inconsistent (some places check it
and
some not).
Err, meant to say I don't have a *strong* opinion :)
https://codereview.chromium.org/378303003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
