On 2014/07/10 14:05:28, marja wrote:
LGTM modulo comments:
Oops, already committed before your reply. Will do that in a follow-up CL.
1) it would be good to add test-parsing tests which use let as an
identifier
(so
we can make sure that Parser and PreParser agree -- no other tests are
testing
that)
2) see below
https://codereview.chromium.org/378303003/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/378303003/diff/20001/src/parser.cc#newcode2082
src/parser.cc:2082: } else if (peek() == Token::LET && strict_mode() ==
STRICT)
{
Here you probably also want to ASSERT(allow_harmony_scoping()) too.
https://codereview.chromium.org/378303003/diff/20001/src/parser.cc#newcode3121
src/parser.cc:3121: } else if (peek() == Token::LET && strict_mode() ==
STRICT)
{
Ditto
https://codereview.chromium.org/378303003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
