On 2014/07/08 at 15:00:02, aperez wrote:
On 2014/07/08 at 08:18:54, marja wrote:
> On 2014/07/08 07:49:59, marja wrote:
> > I reverted this because it fails ASAN:
> >
> >
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/1551/steps/Check/logs/stdio
> >
> > Please create a fixed CL so that the first patch set is the latest patch
set of
> > this, unfixed, and the second patch set is the fix.
>
> Also, we agreed that it's okay to commit non-clang-formatted code in this
case, so your fixed version can have un-formatted test-parsing.cc.

I am on this. And thanks for filing a bug for clang-format :)

Mmhh, I cannot get ASAN to fail here, just some timed out tests which pass
fine if the timeout time is changed. JFTR, this is what I am doing:

   % make asan=/usr/lib/ccache/bin/clang++ -j4 x64.release.check

(Same result on debug builds)

https://codereview.chromium.org/160073006/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to