https://codereview.chromium.org/393283007/diff/50001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/393283007/diff/50001/src/promise.js#newcode41
src/promise.js:41: var promise = PromiseInit(this);
this will fire "update" event before "new". please create a test.
also would be great not to generate "update" right after "new" event.
https://codereview.chromium.org/393283007/diff/50001/src/promise.js#newcode43
src/promise.js:43: %DebugPromiseEvent({ type : "new Promise",
"new"
https://codereview.chromium.org/393283007/diff/50001/src/promise.js#newcode66
src/promise.js:66: %DebugPromiseEvent({ type: "update Promise status",
"update"
https://codereview.chromium.org/393283007/diff/50001/src/promise.js#newcode244
src/promise.js:244: %DebugPromiseEvent({ type: "update Promise parent",
"chain"
https://codereview.chromium.org/393283007/diff/50001/test/mjsunit/es6/debug-promises-new-event.js
File test/mjsunit/es6/debug-promises-new-event.js (right):
https://codereview.chromium.org/393283007/diff/50001/test/mjsunit/es6/debug-promises-new-event.js#newcode15
test/mjsunit/es6/debug-promises-new-event.js:15: if (event_data
instanceof debug.NewPromiseEvent) {
if (!(event_data instanceof debug.NewPromiseEvent)) return;
https://codereview.chromium.org/393283007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
