On 2014/07/24 10:27:29, Alexandra Mikhaylova wrote:
On 2014/07/24 09:18:37, Alexandra Mikhaylova wrote:
>
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js
> File src/debug-debugger.js (right):
>
>
https://codereview.chromium.org/393283007/diff/90001/src/debug-debugger.js#newcode1211
> src/debug-debugger.js:1211: event = new
UpdatePromiseParentEvent(event_data);
> On 2014/07/24 08:43:58, Yang wrote:
> > unless you want to add some common logic later, I don't see why you
can't
just
> > return the event in each if-body directly.
>
> Fixed it.
>
> https://codereview.chromium.org/393283007/diff/90001/src/promise.js
> File src/promise.js (right):
>
>
https://codereview.chromium.org/393283007/diff/90001/src/promise.js#newcode65
> src/promise.js:65: if (DEBUG_IS_ACTIVE && status) {
> On 2014/07/24 08:43:58, Yang wrote:
> > I'd prefer a more explicit "status === 0" here, since the status
constants
are
> > sort of arbitrary. It would also mirror line 80.
>
> Done.
>
>
https://codereview.chromium.org/393283007/diff/90001/test/mjsunit/es6/debug-promises-update-parent-event.js
> File test/mjsunit/es6/debug-promises-update-parent-event.js (right):
>
>
https://codereview.chromium.org/393283007/diff/90001/test/mjsunit/es6/debug-promises-update-parent-event.js#newcode22
> test/mjsunit/es6/debug-promises-update-parent-event.js:22:
parentPromise =
> event_data.parentPromise().value();
> On 2014/07/24 08:43:58, Yang wrote:
> > how about, instead of using a single value for parentPromise, log the
parent
> > promises into an array, and compare the array with the expectation?
>
> Thanks, done. Added an array of promise/parent pairs.
>
>
https://codereview.chromium.org/393283007/diff/90001/test/mjsunit/es6/debug-promises-update-parent-event.js#newcode33
> test/mjsunit/es6/debug-promises-update-parent-event.js:33: var p3 =
p2.then();
> On 2014/07/24 08:43:58, Yang wrote:
> > Instead of a chain of promises, how about having a tree of promises?
like
> adding
> > var p4 = p1.then();
>
> Done.
Actually, we're thinking of merging these 3 "subtypes" of PromiseEvent
(NewPromiseEvent, UpdatePromiseStatusEvent & UpdatePromiseParentEvent)
into
one
with a "type" field.
This would be much more convenient to handle in the DevTools.
WDYT?
That's definitely possile. But Let's do that in a future CL.
https://codereview.chromium.org/393283007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
