https://codereview.chromium.org/393283007/diff/70001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/393283007/diff/70001/src/promise.js#newcode226
src/promise.js:226: %DebugPromiseEvent({ type: "update",
On 2014/07/22 11:58:49, aandrey wrote:
now 3 update event calls instead of one doesn't look good. just revert
to the
previous version and send the event "if (DEBUG_IS_ACTIVE && status)".
Done.
https://codereview.chromium.org/393283007/diff/70001/test/mjsunit/es6/debug-promises-update-parent-event.js
File test/mjsunit/es6/debug-promises-update-parent-event.js (right):
https://codereview.chromium.org/393283007/diff/70001/test/mjsunit/es6/debug-promises-update-parent-event.js#newcode31
test/mjsunit/es6/debug-promises-update-parent-event.js:31:
assertSame(parentPromise, p2);
On 2014/07/22 11:58:49, aandrey wrote:
how many UpdatePromiseParentEvent happened by this time?
this is to test only the latest one?
There should be 3 UpdatePromiseParentEvent's (added a check), and we
check the result of the latest one.
https://codereview.chromium.org/393283007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
