lgtm other than small comments
https://codereview.chromium.org/410153002/diff/1/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/410153002/diff/1/src/factory.cc#newcode1376
src/factory.cc:1376: !isolate()->bootstrapper()->IsActive() &&
Comment me, TODO me?
https://codereview.chromium.org/410153002/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/410153002/diff/1/test/cctest/test-heap.cc#newcode4039
test/cctest/test-heap.cc:4039: if (i::FLAG_always_opt) return;
Can we get a TODO in here? It needs some thought on how to make it work
with more optimized functions, but the coverage is probably worth it.
https://codereview.chromium.org/410153002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/410153002/diff/1/test/cctest/test-parsing.cc#newcode2988
test/cctest/test-parsing.cc:2988: void
MockUseCounterCallback(v8::Isolate* isolate,
While you're here, can you rename this? It's not a mock.
https://codereview.chromium.org/410153002/diff/1/test/mjsunit/debug-compile-event-newfunction.js
File test/mjsunit/debug-compile-event-newfunction.js (right):
https://codereview.chromium.org/410153002/diff/1/test/mjsunit/debug-compile-event-newfunction.js#newcode63
test/mjsunit/debug-compile-event-newfunction.js:63: // Create a function
from its body text. It will lead to an eval.
OK, just TODO someone
https://codereview.chromium.org/410153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
