Thanks. Addressed comments.
https://codereview.chromium.org/410153002/diff/80001/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (left):
https://codereview.chromium.org/410153002/diff/80001/src/arm64/lithium-codegen-arm64.cc#oldcode5038
src/arm64/lithium-codegen-arm64.cc:5038:
ASM_UNIMPLEMENTED_BREAK("DoDeclareGlobals");
On 2014/07/28 16:00:32, jbramley wrote:
We used ASM_UNIMPLEMENTED_BREAK during development. I thought they
were all
gone, to be honest. This one probably remains because we couldn't test
this
code. (That is, it's probably safe to remove it.)
Acknowledged. This actually was the last use. Would you be fine if I
removed the macro (and the related flag) in a follow-up CL or do you
intend to keep this around?
https://codereview.chromium.org/410153002/diff/80001/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/410153002/diff/80001/src/arm64/lithium-codegen-arm64.cc#newcode694
src/arm64/lithium-codegen-arm64.cc:694: __
Push(info()->scope()->GetScopeInfo());
On 2014/07/28 16:00:32, jbramley wrote:
I think it would be slightly better load the scope info explicity so
we can
merge the pushes:
UseScratchRegisterScope temps(masm);
Register scope_info = temps.AcquireX();
__ Mov(scope_info, Operand(info()->scope()->GetScopeInfo()));
__ Push(x1, scope_info);
Each 'Push' has an overhead, and Push(Handle<ScopeInfo>) will just
load the
handle into a scratch register anyway so the 'Mov' here doesn't have
any extra
cost.
Done.
https://codereview.chromium.org/410153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
