Thanks!
lgtm
https://codereview.chromium.org/410153002/diff/80001/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (left):
https://codereview.chromium.org/410153002/diff/80001/src/arm64/lithium-codegen-arm64.cc#oldcode5038
src/arm64/lithium-codegen-arm64.cc:5038:
ASM_UNIMPLEMENTED_BREAK("DoDeclareGlobals");
On 2014/07/28 16:15:53, Michael Starzinger wrote:
On 2014/07/28 16:00:32, jbramley wrote:
> We used ASM_UNIMPLEMENTED_BREAK during development. I thought they
were all
> gone, to be honest. This one probably remains because we couldn't
test this
> code. (That is, it's probably safe to remove it.)
Acknowledged. This actually was the last use. Would you be fine if I
removed the
macro (and the related flag) in a follow-up CL or do you intend to
keep this
around?
I see no reason to keep it. We can recreate it fairly easily if we ever
find that we need it again, but it seems unlikely.
https://codereview.chromium.org/410153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
